Skip to content

Add tip for upper limit of the Email Text Length Limit field range#24253

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
TomashKhamlai:share-wishlist-validate-digits-range
Aug 28, 2019
Merged

Add tip for upper limit of the Email Text Length Limit field range#24253
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
TomashKhamlai:share-wishlist-validate-digits-range

Conversation

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@TomashKhamlai TomashKhamlai commented Aug 23, 2019

Description (*)

Tiny improvement.
image

Fixed Issues (if relevant)

  1. None.

Manual testing scenarios (*)

  1. Review tests. Manual checking is not required

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@TomashKhamlai TomashKhamlai added Component: Wishlist Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Aug 23, 2019
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Aug 23, 2019

Hi @TomashKhamlai. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@TomashKhamlai
Copy link
Copy Markdown
Contributor Author

TomashKhamlai commented Aug 23, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 23, 2019

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@TomashKhamlai
Copy link
Copy Markdown
Contributor Author

TomashKhamlai commented Aug 23, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 23, 2019

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-24253-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 23, 2019

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 23, 2019

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: https://pr-24253.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned sidolov Aug 23, 2019
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 23, 2019

Hi @sidolov, thank you for the review.
ENGCOM-5687 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Aug 27, 2019
@engcom-Delta
Copy link
Copy Markdown
Contributor

engcom-Delta commented Aug 27, 2019

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 27, 2019
magento-engcom-team pushed a commit that referenced this pull request Aug 28, 2019
@sidolov
ENGCOM-5687: Add tip for upper limit of the Email Text Length Limit f…
60e2521 
…ield range #24253
@magento-engcom-team magento-engcom-team merged commit f236c1c into magento:2.3-develop Aug 28, 2019
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Aug 28, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Wishlist Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@TomashKhamlai @magento-engcom-team @engcom-Delta @sidolov @engcom-Foxtrot